Fix collision in QB with nested object & module names #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
requested changes
Mar 11, 2024
There was a problem hiding this comment.
One blocking request: can we add a simple test maybe to https://github.com/edgedb/edgedb-js/blob/master/integration-tests/lts/objectTypes.test.ts to demonstrate the issue and the fix here?
CarsonF
force-pushed
the
bugfix/nested-object-module-collision
branch
2 times, most recently
from
1798993
to
06d8edf
Compare
CarsonF
force-pushed
the
bugfix/nested-object-module-collision
branch
from
06d8edf
to
c568605
Compare
Previously these FQNs A::X::Y B::X::Y were emitted as: import _X from './A/X'; import _X from './B/X'; now they are emitted as: import _AX from './A/X'; import _BX from './B/X'; I opted to use `indentRef.name` instead of path logic. It just seemed easier, but I understand this is a deviation.
Previously these FQNs
A::B
A::B::C
were emitted as:
type __defaultExports = {
"B": typeof B;
"B": typeof _module__B;
};
Now these types & values are merged, just as in generateIndex.
|
I added schema to produce the generation failures. |
scotttrinh
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably need tests, but wanted to get this up before the weekend.
Use full namespace in import
Previously these FQNs
were emitted as:
now they are emitted as:
I opted to use
indentRef.nameinstead of path logic.It just seemed easier, but I understand this is a deviation.
I'm open to changing.
Merged nested objects with nested modules (just like top level)
Previously these FQNs
were emitted as:
Now these types & values are merged, just as in
generateIndex.