Add more metrics #6447
Merged
Add more metrics #6447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fantix
commented
Nov 8, 2023
•
fantix
commented
- Current number of databases.
- Time a client connection is open.
- Number of compiled/cached GraphQL queries.
- Number of SQL queries since instance startup.
- Number of SQL compilations since instance startup.
- Time it takes to compile a query or script.
- Queries per connection (EdgeQL / SQL only).
- Number of transaction serialization errors.
- Number of network errors.
- Number of Auth API calls.
- Number of Auth UI form rendered.
- Number of Auth successful logins.
- Number of OAuth providers configured.
- Average size of queries.
|
Should we consider putting some of this stuff behind authentication? |
Good point! Or perhaps we can serve the /metrics endpoint only on specified host address (like localhost) or from certain client IP |
fantix
force-pushed
the
more-metrics
branch
5 times, most recently
from
a13416c
to
cafdfa3
Compare
fantix
commented
Nov 10, 2023
edb/server/metrics.py
Outdated
| auth_providers = registry.new_labeled_gauge( | ||
| 'auth_providers', | ||
| 'Number of Auth providers configured.', | ||
| labels=('tenant', 'database'), |
There was a problem hiding this comment.
Shall we add database to many other metrics?
msullivan
approved these changes
Mar 8, 2024
scotttrinh
reviewed
Mar 8, 2024
|
(Removing backport-4.x since 4.x doesn't have the auth stuff we need) |
msullivan
pushed a commit
that referenced
this pull request
Mar 15, 2024
* branches_current * graphql_query_compilations_total * sql_queries_total and sql_compilations_total * query_compilation_duration * client_connection_duration * queries_per_connection * transaction_serialization_errors_total * connection_errors_total * query_size * auth_api_calls_total and auth_api_calls_total * auth_providers * auth_successful_logins_total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.