Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine reloadElement and reloadElements #5087

Merged
merged 3 commits into from
May 10, 2024
Merged

combine reloadElement and reloadElements #5087

merged 3 commits into from
May 10, 2024

Conversation

MarcelBolten
Copy link
Contributor

There is no need to maintain two javascript functions to reload HTML elements.
By using a modified reloadElements(elementIds: string[]|string) function we get away with one HTTP request to reload all necessary HTML elements.
This will also address potential issues like // using reloadElements here doesn't work for relativeMoment.

@MarcelBolten MarcelBolten mentioned this pull request May 10, 2024
Open
NicolasCARPi
NicolasCARPi reviewed May 10, 2024
View reviewed changes
src/ts/misc.ts Outdated Show resolved Hide resolved
NicolasCARPi
NicolasCARPi approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@NicolasCARPi NicolasCARPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NicolasCARPi NicolasCARPi merged commit dffd142 into hypernext May 10, 2024
8 of 9 checks passed
@NicolasCARPi NicolasCARPi deleted the marcel-reloadElements branch May 10, 2024 19:31
NicolasCARPi added a commit that referenced this pull request May 18, 2024
@NicolasCARPi
Merge branch 'hypernext' into nico-deeplink
46f3f44 
* hypernext:
  Saml orgid usercreation (#5048)
  combine reloadElement and reloadElements (#5087)
  use composer run-script for psalm and phpstan in package.json
  use nameid in SAML SLO request (#5077)
  Avoid unnecessary casting, use PDO::PARAM_X more cautiously (#5086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasCARPi NicolasCARPi NicolasCARPi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcelBolten @NicolasCARPi