Fix addMetrics() of ShardedLRU

elastic · Mar 20, 2024 · 837c651 · 837c651
1 parent c89e6e0
commit 837c651
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/shardedlru.go b/shardedlru.go
@@ -227,7 +227,7 @@ func (lru *ShardedLRU[K, V]) Metrics() Metrics {
 		m := lru.lrus[shard].Metrics()
 		lru.mus[shard].Unlock()
 
-		addMetrics(metrics, m)
+		addMetrics(&metrics, m)
 	}
 
 	return metrics
@@ -242,13 +242,13 @@ func (lru *ShardedLRU[K, V]) ResetMetrics() Metrics {
 		m := lru.lrus[shard].ResetMetrics()
 		lru.mus[shard].Unlock()
 
-		addMetrics(metrics, m)
+		addMetrics(&metrics, m)
 	}
 
 	return metrics
 }
 
-func addMetrics(dst, src Metrics) {
+func addMetrics(dst *Metrics, src Metrics) {
 	dst.Inserts += src.Inserts
 	dst.Collisions += src.Collisions
 	dst.Evictions += src.Evictions

diff --git a/shardedlru_test.go b/shardedlru_test.go
@@ -49,7 +49,7 @@ func TestShardedRaceCondition(t *testing.T) {
 }
 
 func TestShardedLRUMetrics(t *testing.T) {
-	cache, _ := NewSynced[uint64, uint64](1, hashUint64)
+	cache, _ := NewSharded[uint64, uint64](1, hashUint64)
 	testMetrics(t, cache)
 }