feat: add darwinDarkModeSupport option to support mojave dark mode for older Electron versions #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
requested changes
Oct 1, 2018
docs/api.md
Outdated
| *Boolean* | ||
|
|
||
| Forces support for Mojave dark mode in your packaged app, this sets the `NSRequiresAquaSystemAppearance` | ||
| key to `false` in your apps `Info.plist`. For more information see the |
docs/api.md
Outdated
|
|
||
| Forces support for Mojave dark mode in your packaged app, this sets the `NSRequiresAquaSystemAppearance` | ||
| key to `false` in your apps `Info.plist`. For more information see the | ||
| [apple developer documentation](https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_app) |
MarshallOfSound
force-pushed
the
mojave-dark-mode
branch
from
c4324c2
to
1468aa6
Compare
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
==========================================
- Coverage 94.48% 94.35% -0.14%
==========================================
Files 12 12
Lines 617 620 +3
==========================================
+ Hits 583 585 +2
- Misses 34 35 +1
Continue to review full report at Codecov.
|
…ode for older electron versions
MarshallOfSound
force-pushed
the
mojave-dark-mode
branch
from
1468aa6
to
d57ed03
Compare
malept
changed the title
|
Also, this should be in |
|
The AppVeyor failure is #892 |
malept
changed the title
|
I don't know why codecov asserts that your PR loses coverage. |
malept
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_app