Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ES6ify the documentation JS examples #14842

Closed
ckerr opened this issue Sep 27, 2018 · 11 comments
Closed

feat: ES6ify the documentation JS examples #14842

ckerr opened this issue Sep 27, 2018 · 11 comments

Comments

@ckerr
Copy link
Member

ckerr commented Sep 27, 2018

Case in point: the Desktop Capturer code snippet uses a for (... i++) loop and could use for ... of and uses a Promise and could use async/await

CC @codebytere @sofianguy

@V1shvesh
Copy link

V1shvesh commented Oct 1, 2018

Hey @ckerr!
May I work upon this issue?

@aashish-ak
Copy link

@codebytere May i work on this issue??

@ckerr
Copy link
Member Author

ckerr commented Oct 8, 2018

Hey @V1shvesh, sorry for not responding sooner -- I didn't see your ping until just now.

Yes, anyone including you and @aashish-ak are welcome to work on this. If you are both going to work on it, you may want to coordinate on it so that your work doesn't overlap.

Thank you both for taking a look at this!

@ntocampos
Copy link

ntocampos commented Oct 27, 2018

Hey @ckerr, I would like to help on this one!
I took a look in the docs and saw multiple API Reference sections where the example code can be "es6ified". I'm not sure if I should make a pull-request to each section, or group some of them together in the same PR. What do you recommend?

@MGenteluci
Copy link

MGenteluci commented Nov 27, 2018

Can i grab this issue?
edit: looks like this issue is already done.

@ayushpratap
Copy link

Please, can someone verify if this issue is closed or not?
If the work desired is already done then please mark this issue as closed.

@doc-han
Copy link

doc-han commented Aug 3, 2019

looking at the PR #15507 I'm sure the issue is fixed

@kaustubhdapurkar
Copy link

I am new on GitHub. Can somebody help me get started here? Need a mentor.

@jatin33
Copy link

jatin33 commented Oct 16, 2019

Can I work on this issue?

@Jornn Jornn mentioned this issue Jan 6, 2020
3 tasks
@abuaesh
Copy link

abuaesh commented Jan 14, 2020

I am new on GitHub. Can somebody help me get started here? Need a mentor.

Hey there, welcome to github! Sorry for the late reply, I am as new to github as you are. Even though you may have become an expert by now, here are a few links for everybody's reference:

Free tutorial on how to use git: https://www.udacity.com/course/version-control-with-git--ud123

Guide to contributing to open source projects: https://codeburst.io/a-step-by-step-guide-to-making-your-first-github-contribution-5302260a2940

@Dean-Coakley
Copy link

@zcbenz Should this issue be closed?
Looks like it was completed in: #21686

If not, what work remains?

@zcbenz zcbenz closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests