v4: MenuItems with roles default registerAccelerator to false, breaking all default shortcuts

[pimterry]

• Output of node_modules/.bin/electron --version: v4.0.1
• Operating System (Platform and Version): Ubuntu 18.04

Expected Behavior
The default keyboard shortcuts for menu item roles should be registered (except in special cases where they're handled elsewhere - cut/copy/etc).

Actual behavior
As of v4, the keyboard shortcuts for any menu item with a role are not registered by default.

To Reproduce
In a v4 electron app, adding the below menu item will show a Ctrl/Cmd+R accelerator in the menu, but won't actually register it, so it won't work:

{
  role: 'reload'
}

this menu item does work:

{
  role: 'reload',
  registerAccelerator: true
}

I think this is caused by #15723, specifically

electron/lib/browser/api/menu-item-roles.js

Lines 256 to 258 in a1a431e

	exports.shouldRegisterAccelerator = (role) => {
	return roles.hasOwnProperty(role) ? roles[role].registerAccelerator : true
	}

I.e. registerAccelerator defaults to true only if there's no role for the menu item. If there is a role set, it instead uses the registerAccelerator setting for that role, but for almost all roles this is undefined.

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[codebytere]

Ah, thanks for pointing this out! i'll see what can be done about it 😀

[codebytere]

@pimterry a fix is in flight, it should go out with the next 4-0-x patch release i would guess