fix: register accelerator if role has no registerAccelerator #16309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimterry
reviewed
Jan 7, 2019
miniak
approved these changes
Jan 7, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "4-0-x", please check out #16314 |
akisctx
pushed a commit
to akisctx/electron
that referenced
this pull request
Jan 22, 2019
…n#16309) * fix: register accelerator if role has no registerAccelerator * ensure roles[role].registerAccelerator is defined
|
/trop run backport-to 3-1-x |
|
The backport process for this PR has been manually initiated, |
|
I have automatically backported this PR to "3-1-x", please check out #16598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #16303.
Previously,
registerAcceleratordefaulted totrueonly if there was no role for the menu item. If there is a role set, it instead used theregisterAcceleratorproperty for that role; however many of the roles had anundefinedregisterAccelerator.This therefore changes behavior such that a
MenuItemwill only be set toroles[role].registerAcceleratorif it has a role AND that role has a definedregisterAcceleratorproperty./cc @brenca
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue whereby
registerAcceleratorwas being set to theregisterAcceleratorproperty of its role even whenregisterAcceleratorwasundefined.