Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backport patch to sync exposed crypto (backport: 4-0-x) #16912

Merged
merged 4 commits into from Feb 13, 2019
Merged

fix: backport patch to sync exposed crypto (backport: 4-0-x) #16912

merged 4 commits into from Feb 13, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 12, 2019

Backport of #16822

See that PR for details.

Notes: Added a patch to fix incorrect enumeration and instantiation of Node.js ciphers in the Crypto module.

@trop trop bot requested a review from a team February 12, 2019 20:31
@trop trop bot mentioned this pull request Feb 12, 2019
Merged
5 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Feb 12, 2019
@nornagon
Copy link
Member

merging; ci appears to be flake

@nornagon nornagon merged commit 4f63509 into electron:4-0-x Feb 13, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 13, 2019 •
edited by nornagon

Release Notes Persisted

Some ciphers that were listed in crypto.getCiphers() were not instantiable with crypto.createCipheriv(). Now they are.

@jamesb3ll jamesb3ll mentioned this pull request Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @codebytere