New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: backport patch to sync exposed crypto #16822
Conversation
FYI, that patch may change a little still before it gets merged upstream so we may need to update this. |
@nornagon @ryzokuken all set, ptal when you can 🙇♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ LGTM. Thanks.
Flake on linux tests that is unrelated! Merging. |
Release Notes Persisted
|
I have automatically backported this PR to "5-0-x", please check out #16909 |
/trop run backport-to 4-0-x |
The backport process for this PR has been manually initiated, |
I have automatically backported this PR to "4-0-x", please check out #16912 |
Description of Change
Closes #16812.
Backports https://boringssl-review.googlesource.com/c/boringssl/+/33984 to our patch set in order to correctly enumerate and instantiate ciphers. Also adds a test to ensure that
DES-EDE-CBC
actually works.cc @nornagon
Checklist
npm test
passesRelease Notes
Notes: Added a patch to fix incorrect enumeration and instantiation of Node.js ciphers in the Crypto module.