Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport patch to sync exposed crypto #16822

Merged
merged 4 commits into from Feb 12, 2019
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Feb 7, 2019

Description of Change

Closes #16812.

Backports https://boringssl-review.googlesource.com/c/boringssl/+/33984 to our patch set in order to correctly enumerate and instantiate ciphers. Also adds a test to ensure that DES-EDE-CBC actually works.

cc @nornagon

Checklist

Release Notes

Notes: Added a patch to fix incorrect enumeration and instantiation of Node.js ciphers in the Crypto module.

@codebytere codebytere requested a review from a team February 7, 2019 20:01
@nornagon
Copy link
Member

nornagon commented Feb 7, 2019

FYI, that patch may change a little still before it gets merged upstream so we may need to update this.

spec/node-spec.js Outdated Show resolved Hide resolved
@codebytere
Copy link
Member Author

@nornagon @ryzokuken all set, ptal when you can 🙇‍♀️

@codebytere codebytere changed the title [wip] fix: backport patch to sync exposed crypto fix: backport patch to sync exposed crypto Feb 12, 2019
Copy link

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ LGTM. Thanks.

@codebytere
Copy link
Member Author

Flake on linux tests that is unrelated! Merging.

@codebytere codebytere merged commit cfba599 into master Feb 12, 2019
@codebytere codebytere deleted the crypto-sort-patch branch February 12, 2019 19:57
@release-clerk
Copy link

release-clerk bot commented Feb 12, 2019

Release Notes Persisted

Some ciphers that were listed in crypto.getCiphers() were not instantiable with crypto.createCipheriv(). Now they are.

@trop
Copy link
Contributor

trop bot commented Feb 12, 2019

I have automatically backported this PR to "5-0-x", please check out #16909

@codebytere
Copy link
Member Author

/trop run backport-to 4-0-x

@trop
Copy link
Contributor

trop bot commented Feb 12, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Feb 12, 2019

I have automatically backported this PR to "4-0-x", please check out #16912

@sofianguy sofianguy added this to 5.0.0-beta.3 in 5.0.x Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.0-beta.3
Development

Successfully merging this pull request may close these issues.

Expose cipher DES-EDE-CBC in Electron 4 crypto module
3 participants