loadURL / loadFile calls throw "ERR_ABORTED (-3) error" if location.hash or history.pushState called on the page before page loaded #17526

vladimiry · 2019-03-24T12:35:26Z

Electron v5.0.0-beta.6 will likely break every single page application / SPA that uses routing as it's uncommon to trigger the routing only after the page loading event has been fired. See workaround in additional Information section below.

Issue Details

Electron Version:
- 5.0.0-beta.6 +
Operating System:
- any (tested on linux)
Last Known Working Electron version:
- 4.1.1

Expected Behavior

Page loading completes without errors even if that's a SPA.

Actual Behavior

window.location.hash = '123' called on page:

{ Error: ERR_ABORTED (-3) loading 'file:////dev/temp/electron-loadurl-issue/page.html#123'
    at rejectAndCleanup (//dev/temp/electron-loadurl-issue/node_modules/electron/dist/resources/electron.asar/browser/navigation-controller.js:72:21)
    at WebContents.navigationListener (//dev/temp/electron-loadurl-issue/node_modules/electron/dist/resources/electron.asar/browser/navigation-controller.js:93:20)
    at WebContents.emit (events.js:193:15)
  errno: -3,
  code: 'ERR_ABORTED',
  url:
   'file:////dev/temp/electron-loadurl-issue/page.html#123' }

history.pushState({}, "title", "url") called on page:

{ Error: ERR_ABORTED (-3) loading 'file:////dev/temp/electron-loadurl-issue/url'
    at rejectAndCleanup (//dev/temp/electron-loadurl-issue/node_modules/electron/dist/resources/electron.asar/browser/navigation-controller.js:72:21)
    at WebContents.navigationListener (//dev/temp/electron-loadurl-issue/node_modules/electron/dist/resources/electron.asar/browser/navigation-controller.js:93:20)
    at WebContents.emit (events.js:193:15)
  errno: -3,
  code: 'ERR_ABORTED',
  url: 'file:////dev/temp/electron-loadurl-issue/url' }

To Reproduce

main.js:

const path = require("path");
const url = require("url");
const {app, BrowserWindow} = require("electron");

app.on("ready", async () => {
    const browserWindow = new BrowserWindow();

    browserWindow.webContents.on("did-start-navigation", (event, url) => {
        console.log("did-start-navigation", {url});
    });

    try {
        await browserWindow.loadURL(
            url.format({
                protocol: "file",
                slashes: true,
                pathname: path.join(__dirname, "page.html")
            })
        );
    } catch (e) {
        console.error(e);
    }

    // "loadFile" gives the same result
    // try {
    //     await browserWindow.loadFile(
    //         path.join(__dirname, "page.html"),
    //     );
    // } catch (e) {
    //     console.error(e);
    // }
});

page.html:

<!DOCTYPE html>
<html>
<body>
<script>
    window.location.hash = '123';
    // history.pushState({}, "title", "url"); // second case
</script>
</body>
</html>

Screenshots

N/A

Additional Information

The workaround is changing the hash / history state afte page got loaded:

<!DOCTYPE html>
<html>
<script>
    function onload() {
        window.location.hash = '123';
        // history.pushState({}, "title", "url"); // second case
    }
</script>
<body onload="onload">
</body>
</html>

See relater PR #15855 and code line https://github.com/electron/electron/pull/15855/files#diff-fc5b6704bed639bfab5927de1eccbcc3R85

CC @nornagon

The text was updated successfully, but these errors were encountered:

MarshallOfSound · 2019-03-28T22:03:18Z

Hey @vladimiry

This is currently the expected behavior, the promise that loadURL returns will be rejected if the renderer for whatever reason fails to completely load that URL.

If you navigate before the page has completed loading you have aborted that load, hence the ERR_ABORTED rejection.

vladimiry · 2019-03-29T03:40:54Z

@MarshallOfSound I still believe such logic is going to break a lot of SPA apps, but I got it that it's expected behavior. There are a few points I'd like you to consider:

Changing the hash or push state is not really navigation, the new page loading process is not involved but only the url gets changed, ie changing the hash or push state is completely happening on the client side (browser side in term of server-client scenario).
The currently shown error is vague, I had to look into the sources in order to understand why exactly page loading got aborted.

MarshallOfSound · 2019-03-29T18:47:24Z

@vladimirkononov

I still believe such logic is going to break a lot of SPA apps

How can it break apps? This feature was only just introduced in 5.0.0, it didn't exist in any other state before that version.

vladimiry · 2019-03-29T19:15:28Z

@MarshallOfSound Single page applications often use routing based on either html5 history api (push state thing) or url hash. Normally SPA doesn't wait for the full page loading but starts working asap which means html5 hitstory or url hash might be changed before page got fully loaded and it doesn't mean that a new page starts loading but it's only the client side url change. This is actually how I noticed the problem in action. See applied workaround here
https://github.com/vladimiry/ElectronMail/blob/0fb48fa16fe4dcf0370a9004c4556f0716941377/src/web/src/environments/production/bootstrap-app.ts#L10 as an example.

This feature was only just introduced in 5.0.0

Correct. I started trying v5 beta in action and I open issues if I face bugs or blockers (this one, for example, got successfully fixed). I think it's better to handle the apparent issue before final v5 release gets published.

I think at least making the error message more detailed would be a good idea.

cyphercodes · 2019-05-01T21:47:05Z

This is also blocking loading dataURL like so:

browserWindow.webContents.loadURL('data:text/html;charset=utf-8,' + encodeURIComponent(html), {
      baseURLForDataURL: httpHost,
});

vladimiry · 2019-05-01T22:04:16Z

If you navigate before the page has completed loading you have aborted that load, hence the ERR_ABORTED rejection.

I will just repeat. Calling history.pushState or changing the location.hash value does trigger reloading the page, so the loaded page remains the same. This is why expected behavior does not look good for me.

cyphercodes · 2019-05-30T13:16:51Z

This is also blocking loading dataURL like so:

browserWindow.webContents.loadURL('data:text/html;charset=utf-8,' + encodeURIComponent(html), {
      baseURLForDataURL: httpHost,
});

This is still happening even after 5.0.2

* as electron/electron#17526 got resolved

preslavsh · 2019-09-23T10:17:33Z

Still happening in 6.0.9. I not sure what the proper behavior should be, but it causes pain when I want to load angular hash route from electron. My case is notification window should open hash route on the main window.

vladimiry · 2019-09-23T10:22:39Z

@preslavsh you could try bootstrapping the Angular app in window.addEventListener("load" handler, ugly workaround though.

* as electron/electron#17526 got resolved

sofianguy added platform/linux bug 🪲 5-0-x labels Mar 25, 2019

sofianguy added this to Unsorted Issues in 5.0.x Mar 25, 2019

sofianguy assigned MarshallOfSound Mar 28, 2019

sofianguy moved this from Unsorted Issues to Doesn't Block Stable in 5.0.x Mar 28, 2019

MarshallOfSound closed this as completed Mar 28, 2019

MarshallOfSound mentioned this issue May 1, 2019

fix: do not mark navigations interupted with same-document navigations as aborted #18109

Merged

vladimiry added a commit to vladimiry/ElectronMail that referenced this issue Jun 16, 2019

web: get back immediate bootstrapping

52a7255

* as electron/electron#17526 got resolved

vladimiry added a commit to vladimiry/ElectronMail that referenced this issue Jun 17, 2019

web: get back immediate bootstrapping

c73c33c

* as electron/electron#17526 got resolved

vladimiry mentioned this issue Jun 13, 2020

Request for better documentation around window.loadURL #24113

Closed

3 tasks

benoittgt mentioned this issue Feb 1, 2021

loadUrl error "ERR_ABORTED (-3) error" can't be catched #27574

Closed

3 tasks

pushkin- mentioned this issue Mar 22, 2021

[Bug]: clicking on a link before loadURL has resolved causes the promise to reject, even if the link navigation was prevented #28338

Closed

3 tasks

spywhere mentioned this issue May 25, 2022

On macOS, main window cannot be activate if closed without --fast-quit option nativefier/nativefier#1415

Closed

4 tasks

devDefiWeb added a commit to devDefiWeb/electron-mail-app that referenced this issue May 28, 2022

web: get back immediate bootstrapping

d79d291

* as electron/electron#17526 got resolved

zroger mentioned this issue Apr 27, 2023

Crash using OAuth2 authorization Kong/insomnia#5926

Closed

1 task

gustavokath mentioned this issue Mar 29, 2024

fix(#1920): Ignore redirect abortion emmited by loadUrl usebruno/bruno#1959

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

loadURL / loadFile calls throw "ERR_ABORTED (-3) error" if location.hash or history.pushState called on the page before page loaded #17526

loadURL / loadFile calls throw "ERR_ABORTED (-3) error" if location.hash or history.pushState called on the page before page loaded #17526

vladimiry commented Mar 24, 2019 •

edited

MarshallOfSound commented Mar 28, 2019

vladimiry commented Mar 29, 2019 •

edited

MarshallOfSound commented Mar 29, 2019

vladimiry commented Mar 29, 2019 •

edited

cyphercodes commented May 1, 2019

vladimiry commented May 1, 2019

cyphercodes commented May 30, 2019

preslavsh commented Sep 23, 2019

vladimiry commented Sep 23, 2019 •

edited

loadURL / loadFile calls throw "ERR_ABORTED (-3) error" if location.hash or history.pushState called on the page before page loaded #17526

loadURL / loadFile calls throw "ERR_ABORTED (-3) error" if location.hash or history.pushState called on the page before page loaded #17526

Comments

vladimiry commented Mar 24, 2019 • edited

Issue Details

Expected Behavior

Actual Behavior

To Reproduce

Screenshots

Additional Information

MarshallOfSound commented Mar 28, 2019

vladimiry commented Mar 29, 2019 • edited

MarshallOfSound commented Mar 29, 2019

vladimiry commented Mar 29, 2019 • edited

cyphercodes commented May 1, 2019

vladimiry commented May 1, 2019

cyphercodes commented May 30, 2019

preslavsh commented Sep 23, 2019

vladimiry commented Sep 23, 2019 • edited

vladimiry commented Mar 24, 2019 •

edited

vladimiry commented Mar 29, 2019 •

edited

vladimiry commented Mar 29, 2019 •

edited

vladimiry commented Sep 23, 2019 •

edited