Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump libcc (3-1-x) #18426

Conversation

electron-bot
Copy link
Contributor

@electron-bot electron-bot commented May 23, 2019

Fixes #18420
Updating libcc reference to latest. Changes since the last roll:

  • d84bd5a5 fix: include v8 flags used by electron

mksnapshot comes from the ffmpeg build and needs the same v8 flags used for the static library build

fix: include v8 flags used by electron in mksnapshot build

Notes: no-notes

@ckerr
Copy link
Member

ckerr commented May 24, 2019

@jkleinsc pointed out that there are known CI issues in 3-1-x and so @MarshallOfSound suggested using #18283 as a baseline since it's a recent 3-1-x PR that just bumps a package.json dependency. And build-ia32, build-x64, and appveyor: win-x64-testing all fail both PRs.

However appveyor: win-ia32-testing is failing here but passing in #18283. When I compare the logs (18283, 18426) these warnings occur several times here but not in 18283:

ERROR:gpu_process_host.cc(465)]

ERROR:process_win.cc(151)] Unable to terminate process: Access is denied. (0x5)

The two failing tests are:

[00:09:17] not ok 51 app module mixed sandbox option when app.enableMixedSandbox() is called adds --enable-sandbox to render processes created with sandbox: true
[00:09:17]   Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\projects     \electron-ia32-testing\spec\api-app-spec.js
[00:09:17]       at Test.Runnable._timeoutError (C:\projects\electron-ia32-testing\spec\node_modules\mocha\lib\runnable.js:440:10)
[00:09:17]       at C:\projects\electron-ia32-testing\spec\node_modules\mocha\lib\runnable.js:251:24
[00:09:47] not ok 52 app module mixed sandbox option when the app is launched with --enable-mixed-sandbox adds --enable-sandbox to render processes created wit     h sandbox: true
[00:09:47]   Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\projects     \electron-ia32-testing\spec\api-app-spec.js
[00:09:47]       at Test.Runnable._timeoutError (C:\projects\electron-ia32-testing\spec\node_modules\mocha\lib\runnable.js:440:10)
[00:09:47]       at C:\projects\electron-ia32-testing\spec\node_modules\mocha\lib\runnable.js:251:24

@codebytere
Copy link
Member

codebytere commented May 24, 2019

those two failures used to happen a lot on that branch iirc 🤔

@ckerr
Copy link
Member

ckerr commented May 24, 2019

To partially rule out flakes: I re-ran both appveyor: win-ia32-testing again for both 18283 and 18426 and had the same results

@jkleinsc
Copy link
Contributor

Windows CI is now passing;

Linux CI the test are passing but it times out trying to shutdown dbusmock, so I think this PR can be merged as is.

@codebytere codebytere merged commit 1e12291 into 3-1-x May 29, 2019
@release-clerk
Copy link

release-clerk bot commented May 29, 2019

No Release Notes

@codebytere codebytere deleted the roller/libcc-55625e1de5d34a815921975f4d5556133b8142af-1558631297897 branch May 29, 2019 15:38
@sofianguy sofianguy added this to Fixed (3.1.10) in 3.0.x / 3.1.x May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3.0.x / 3.1.x
Fixed (3.1.10)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants