Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap OnWindowMessage w/ handlescope #24769

Merged
merged 2 commits into from Jul 29, 2020
Merged

fix: wrap OnWindowMessage w/ handlescope #24769

merged 2 commits into from Jul 29, 2020

Conversation

nornagon
Copy link
Member

Backport of #24716.

Notes: Fixed a crash that could happen when using hookWindowMessage on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 28, 2020
@trop trop bot mentioned this pull request Jul 28, 2020
Merged
7 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jul 28, 2020
@nornagon nornagon changed the title fix: wrap OnWindowMessage w/ handlescope (#24716) fix: wrap OnWindowMessage w/ handlescope Jul 28, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 28, 2020
@MarshallOfSound MarshallOfSound merged commit 72d921e into 9-x-y Jul 29, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 29, 2020

Release Notes Persisted

Fixed a crash that could happen when using hookWindowMessage on Windows.

@MarshallOfSound MarshallOfSound deleted the backport/9-x-y/onwindowmessage-handlescope branch July 29, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @MarshallOfSound