Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap OnWindowMessage w/ handlescope #24716

Merged
merged 5 commits into from Jul 28, 2020
Merged

fix: wrap OnWindowMessage w/ handlescope #24716

merged 5 commits into from Jul 28, 2020

Conversation

nornagon
Copy link
Member

Description of Change

Fixes a crash that some apps were seeing when restoring windows.

Checklist

Release Notes

Notes: Fixed a crash that could happen when using hookWindowMessage on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 24, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2020
@nornagon nornagon mentioned this pull request Jul 28, 2020
Closed
5 tasks
@nornagon nornagon merged commit 834408a into master Jul 28, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 28, 2020

Release Notes Persisted

Fixed a crash that could happen when using hookWindowMessage on Windows.

@nornagon nornagon deleted the onwindowmessage-handlescope branch July 28, 2020 22:10
@trop
Copy link
Contributor

trop bot commented Jul 28, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jul 28, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

nornagon added a commit that referenced this pull request Jul 28, 2020
@nornagon
fix: wrap OnWindowMessage w/ handlescope (#24716)
49e6f5c
@nornagon nornagon mentioned this pull request Jul 28, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Jul 28, 2020

@nornagon has manually backported this PR to "10-x-y", please check out #24768

nornagon added a commit that referenced this pull request Jul 28, 2020
@nornagon
fix: wrap OnWindowMessage w/ handlescope (#24716)
c099de0
@nornagon nornagon mentioned this pull request Jul 28, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Jul 28, 2020

@nornagon has manually backported this PR to "9-x-y", please check out #24769

MarshallOfSound pushed a commit that referenced this pull request Jul 29, 2020
@nornagon
fix: wrap OnWindowMessage w/ handlescope (#24769)
72d921e 
* fix: wrap OnWindowMessage w/ handlescope (#24716)

* Update electron_api_top_level_window.cc
MarshallOfSound pushed a commit that referenced this pull request Jul 29, 2020
@nornagon
fix: wrap OnWindowMessage w/ handlescope (#24716) (#24768)
99f1d7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 left review comments

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nornagon @deepak1556 @codebytere @MarshallOfSound