Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Frameless windows have no animation on Windows #32993

Closed
3 tasks done
mxmou opened this issue Feb 19, 2022 · 13 comments
Closed
3 tasks done

[Bug]: Frameless windows have no animation on Windows #32993

mxmou opened this issue Feb 19, 2022 · 13 comments

Comments

@mxmou
Copy link

mxmou commented Feb 19, 2022

Preflight Checklist

Electron Version

17.0.1

What operating system are you using?

Windows

Operating System Version

Windows 11 (21H2, build 22000.493)

What arch are you using?

x64

Last Known Working Electron version

16.0.8

Expected Behavior

Frameless windows would show an animation when minimized or maximized.

Actual Behavior

There is no animation.

Testcase Gist URL

https://gist.github.com/mxmou/cb865ea440a2bbbd21673fa40cf39bb4

Additional Information

No response

@mxmou mxmou added the bug 🪲 label Feb 19, 2022
@pejman1
Copy link

pejman1 commented Feb 24, 2022

same issue in electron version 16.0.9 and 17.1.0 In Windows 10

@itsgoofer
Copy link

Same issue in electron 15.4.0.

@McSon2
Copy link

McSon2 commented Mar 3, 2022

Same here

@xpirt
Copy link

xpirt commented Mar 8, 2022

I confirm the issue happening on 17.1.1 version.

@mlaurencin
Copy link
Contributor

As stated in #33152, #32692 might have caused the issue and would be a good place to start for resolving it.

@Levminer
Copy link

Still present in 18.0.0.

@pejman1
Copy link

pejman1 commented Apr 2, 2022

@ckerr
it is really important bug after two major releases
the issue has not fixed yet . version 18.0.1

@DogFoxX
Copy link

DogFoxX commented Apr 6, 2022

I also upgraded to 18.0.1 and still had this issue... but after trying (and not succeeding) this answer on #33152, the issue resolved itself.
I cannot say what happened, but I removed the code suggested by that answer, and animations for Minimize and Maximize was back. Could it be that there is underlying code for the animations that are being ignored?

@pejman1
Copy link

pejman1 commented Apr 6, 2022

I also upgraded to 18.0.1 and still had this issue... but after trying (and not succeeding) this answer on #33152, the issue resolved itself. I cannot say what happened, but I removed the code suggested by that answer, and animations for Minimize and Maximize was back. Could it be that there is underlying code for the animations that are being ignored?

it has been fixed in the latest version 18.0.2

@DogFoxX
Copy link

DogFoxX commented Apr 6, 2022

@pejman1 Ah right, thanx. Just did the update.

@mikeseese
Copy link

To gather all the information in one spot, as I currently understand, #33599 fixes this issue. Below is how this PR has propagated to various versions

Fix released:

Fix merged but not released:

Fix pending merge:

@mxmou mxmou closed this as completed Sep 6, 2022
@mbeissinger
Copy link

I'm still seeing this issue on version 21.2.11

@mikeseese
Copy link

@mbeissinger you should open a new issue for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests