fix: get background color from GtkMenuBar#menubar #14785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
Sep 24, 2018
atom/browser/ui/views/menu_bar.cc
Outdated
|
|
||
| #include "atom/browser/ui/views/menu_delegate.h" | ||
| #include "atom/browser/ui/views/submenu_button.h" | ||
| #include "chrome/browser/ui/libgtkui/gtk_util.h" |
There was a problem hiding this comment.
this also needs to be guarded by USE_X11
codebytere
force-pushed
the
fix-gtk-menubar-bg
branch
from
6f3bdff
to
691eeaa
Compare
codebytere
changed the title
alexeykuzmin
approved these changes
Sep 25, 2018
|
Release Notes Persisted
|
|
I'm gonna have to roll these patch changes into libcc to backport them 💀 |
This was referenced Sep 25, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #13381.
Changes the background color of the menubar to match the GTK theme if there is one.
Checklist
npm testpassesRelease Notes
Notes: fixes incorrect background color on GTK menubar