refactor: remove hardcoded google api key #15478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
ckerr
reviewed
Oct 30, 2018
docs/api/environment-variables.md
Outdated
| webservice. Because this API key is included in every version of Electron, it | ||
| often exceeds its usage quota. To work around this, you can supply your own | ||
| Google API key in the environment. Place the following code in your main process | ||
| You can supply your own Google API key in the environment. Place the following code in your main process |
There was a problem hiding this comment.
This loses the context that the previous revision had of "what is this key for."
Maybe something like
You can provide an API key for making requests to Google's geocoding webservice. To do this, place the following code in your main process
|
@ckerr |
ckerr
approved these changes
Oct 31, 2018
|
Release Notes Persisted
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove hardcoded Google API key as current pricing tiers and requirements have precluded it from working in a free capacity for quite some time. Update documentation to reflect that it must now exclusively be passed in via env var.
/cc @zcbenz
Checklist
npm testpassesRelease Notes
Notes: remove hardcoded Google API key