Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash in sandbox on linux when getting execPath #15701

Merged
merged 4 commits into from Nov 15, 2018
Merged

fix: crash in sandbox on linux when getting execPath #15701

merged 4 commits into from Nov 15, 2018

Commits on Nov 13, 2018

  1. fix: remove execPath and resourcesPath from sandbox process 

    calling base::PathService::Get(base::FILE_EXE, &path) on linux crashes in sandbox.
    @nornagon
    nornagon committed Nov 13, 2018
    Copy the full SHA
    cefc6af View commit details
    Browse the repository at this point in the history

  2. pass helperExecPath as execPath

    @nornagon
    nornagon committed Nov 13, 2018
    Copy the full SHA
    ac4bd4f View commit details
    Browse the repository at this point in the history

  3. remove spec tests for resourcesPath

    @nornagon
    nornagon committed Nov 13, 2018
    Copy the full SHA
    c255136 View commit details
    Browse the repository at this point in the history

  4. restore execPath to docs

    @nornagon
    nornagon committed Nov 13, 2018
    Copy the full SHA
    a5a5d6d View commit details
    Browse the repository at this point in the history