Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promisify app.getFileIcon() #15742

Merged
merged 12 commits into from Dec 5, 2018
Merged

feat: promisify app.getFileIcon() #15742

merged 12 commits into from Dec 5, 2018

Commits on Dec 4, 2018

  1. feat: promisify app.getFileIcon

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    32f43bf View commit details
    Browse the repository at this point in the history

  2. update docs for new signature

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    ce88eea View commit details
    Browse the repository at this point in the history

  3. fix dcheck on invalidated handle

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    1020868 View commit details
    Browse the repository at this point in the history

  4. update getFileIcon specs

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    4a0776b View commit details
    Browse the repository at this point in the history

  5. don't include iostream

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    0fd2e5a View commit details
    Browse the repository at this point in the history

  6. clarify promise resolution value

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    bad4e9b View commit details
    Browse the repository at this point in the history

  7. document changes in api contract

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    d4a4ede View commit details
    Browse the repository at this point in the history

  8. properly deprecate method for backwards compat

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    ed4247b View commit details
    Browse the repository at this point in the history

  9. update docs

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    f09e3b6 View commit details
    Browse the repository at this point in the history

  10. add deprecation relative link

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    7700bb1 View commit details
    Browse the repository at this point in the history

  11. use handlescope

    @codebytere
    codebytere committed Dec 4, 2018
    Copy the full SHA
    c0f1dfe View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. cleanup

    @codebytere
    codebytere committed Dec 5, 2018
    Copy the full SHA
    c089bf7 View commit details
    Browse the repository at this point in the history