Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update mojave-dark-mode-guide.md #15888

Merged
merged 3 commits into from Dec 1, 2018
Merged

docs: update mojave-dark-mode-guide.md #15888

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d44edba
Update mojave-dark-mode-guide.md
JB1905 Nov 29, 2018
0be7543
Update mojave-dark-mode-guide.md
JB1905 Nov 30, 2018
1728286
Update mojave-dark-mode-guide.md
JB1905 Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/tutorial/mojave-dark-mode-guide.md
View file
Open in desktop
Expand Up @@ -24,8 +24,7 @@ to set the `NSRequiresAquaSystemAppearance` key in your app's `Info.plist` file
</plist>
```

If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager) or
[`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) you can set the
If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager), [`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) or [`electron-builder` >= 20.37.0](https://github.com/electron-userland/electron-builder) you can set the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the builder reference should be put in a new paragraph beneath this one with its own links to builders option name. Builders option is not the same as forges / packagers.

[`darwinDarkModeSupport`](https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#darwindarkmodesupport)
MarshallOfSound marked this conversation as resolved.
Show resolved Hide resolved
option when packaging and this key will be set for you.

Expand Down