Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use helpers for command-line parsing in renderer/init.js #16239

Merged
merged 1 commit into from Jan 3, 2019
Merged

refactor: use helpers for command-line parsing in renderer/init.js #16239

merged 1 commit into from Jan 3, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 2, 2019 •
edited

Description of Change

Makes the command-line parsing more robust.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak force-pushed the miniak/init-commandline branch 2 times, most recently from 11b7eb9 to 074527a Compare January 2, 2019 22:58
nornagon
nornagon requested changes Jan 2, 2019
View reviewed changes
lib/renderer/command-line.js Outdated Show resolved Hide resolved
nornagon
nornagon requested changes Jan 2, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this change, i think it would be even better if we used CommandLine::HasSwitch directly!

@miniak
Copy link
Contributor Author

miniak commented Jan 3, 2019 •
edited

@nornagon I've exposed hasSwitch and getSwitchValue wrapping base::CommandLine from native code

deepak1556
deepak1556 requested changes Jan 3, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test seems related to this PR.

atom/browser/web_contents_preferences.cc Outdated Show resolved Hide resolved
atom/common/api/atom_api_command_line.cc Outdated Show resolved Hide resolved
@miniak miniak mentioned this pull request Jan 3, 2019
Merged
6 tasks
@miniak
Copy link
Contributor Author

miniak commented Jan 3, 2019

@deepak1556 all comments should be addressed

@jkleinsc
Copy link
Contributor

jkleinsc commented Jan 3, 2019

Merging with failing arm test as it is broken in master

@jkleinsc jkleinsc merged commit 3f1d227 into master Jan 3, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 3, 2019

No Release Notes

@nornagon nornagon mentioned this pull request Jan 4, 2019
Merged
@codebytere codebytere deleted the miniak/init-commandline branch January 4, 2019 16:25
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
@miniak @akisctx
refactor: use helpers for command-line parsing in renderer/init.js (e…
5078cba 
…lectron#16239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@alexeykuzmin alexeykuzmin Awaiting requested review from alexeykuzmin

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @jkleinsc @nornagon @deepak1556