feat: add fileMenu / viewMenu / appMenu roles #16328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
miniak
changed the title
fileMenu / viewMenu / appMenu roles
miniak
force-pushed
the
miniak/menu-roles
branch
from
e0c97bb
to
9c7dc8c
Compare
miniak
force-pushed
the
miniak/menu-roles
branch
2 times, most recently
from
ecebb9b
to
433542c
Compare
miniak
force-pushed
the
miniak/menu-roles
branch
from
433542c
to
59be8f5
Compare
alexeykuzmin
reviewed
Jan 9, 2019
| ] | ||
| }, | ||
| // { role: 'viewMenu' } |
There was a problem hiding this comment.
Is it needed here? If is a comment, I don't really understand what it means =/
There was a problem hiding this comment.
It was mean to suggest that it’s equivalent of using those menu roles
codebytere
approved these changes
Jan 10, 2019
alexeykuzmin
approved these changes
Jan 10, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This allows the default menu code to be simplified significantly.
Checklist
npm testpassesRelease Notes
Notes: Added
fileMenu/viewMenu/appMenuroles