Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: registerStreamProtocol callback with large chunks #16532

Merged
merged 2 commits into from Jan 25, 2019
Merged

fix: registerStreamProtocol callback with large chunks #16532

merged 2 commits into from Jan 25, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jan 24, 2019 •
edited

Description of Change

This fixes a bug in the registerStreamProtocol API that was introduced in Electron 4. The response was being closed before the data in the stream was exhausted.

Checklist

Release Notes

Notes: Fixed an issue where data streamed from registerStreamProtocol could be truncated before completion.

@nornagon nornagon requested review from zcbenz, felixrieseberg and a team January 24, 2019 18:26
@nornagon
Copy link
Member Author

Marked [wip] because this should be commit as xit, but I'll wait for CI to show the failure before I update.

@nornagon
Copy link
Member Author

Ref #16213

@nornagon nornagon changed the title test: add a failing test for large chunks in registerStreamProtocol fix: registerStreamProtocol callback with large chunks Jan 24, 2019
@nornagon nornagon removed the wip ⚒ label Jan 24, 2019
@nornagon nornagon mentioned this pull request Jan 24, 2019
Closed
@trop

This comment has been minimized.

Sign in to view
@nornagon nornagon mentioned this pull request Jan 24, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jan 24, 2019

A maintainer has manually backported this PR to "4-0-x", please check out #16540

@nornagon nornagon merged commit 63bf370 into master Jan 25, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 25, 2019

Release Notes Persisted

Fixed an issue where data streamed from registerStreamProtocol could be truncated before completion.

@trop trop bot mentioned this pull request Jan 25, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jan 25, 2019

I have automatically backported this PR to "5-0-x", please check out #16553

@nornagon nornagon deleted the stream-protocol-test branch January 25, 2019 18:59
@trop
Copy link
Contributor

trop bot commented Jan 25, 2019

A maintainer has manually backported this PR to "4-0-x", please check out #16540

@jkleinsc jkleinsc mentioned this pull request Jan 28, 2019
Closed
@sofianguy sofianguy added this to 5.0.0-beta.2 in 5.0.x Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@felixrieseberg felixrieseberg Awaiting requested review from felixrieseberg

Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.0-beta.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @zcbenz @codebytere