fix: registerStreamProtocol callback with large chunks (backport: 4-0-x) #16539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 35df516.
) This reverts commit c8a9a3f.
* fix: update and enable osr * fix: update MacHelper view to call GetNativeView * style: move stuff around to make more sense * chore: move OSR related things in SetOwnerWindow to CommonWebContentsDelegate * fix: avoid crashing when GetOffscreenRenderWidgetHostView is called * fix: specify default for current_device_scale_factor_
* fix: Small JS assignment error * fix: Call the right og method * fix: Goodbye, statSyncNoException
picks up: - electron/node#73: fix: export libuv symbols - electron/node#74: fix: include names.h in zlib header package
* fix: natively implement some LoginItem functions * move url_ref inside loop
I think it's safe to say this API has been around long enough to be considered past the experimental phase 👍
…15136) * ci: breakup dump symbols into multiple steps. * Update step-zip-symbols
* fix: preserve background color through reload * fix: only set backgroundColor on top-level frames
docs: deprecation warning for using nativeWindowOpen with nodeIntegration (4-0-x)
* fix: require('@electron/internal/browser/guest-view-manager')
* fix: add missing crashServicePid used by tests
This reverts commit da6079e.
Manual backport of #16343 to 4-0-x.
…ed (backport: 4-0-x) (#16376) * fix: emit IPC event in correct context if isolation and sandbox enabled IPC events were not being delivered to renderer processes when both `contextIsolation` and `sandbox` were enabled. This is because the `AtomSandboxedRenderFrameObserver` class was incorrectly using the `MainWorldScriptContext`, rather than conditionally selecting the context based on if isolation was enabled. Fixes #11922
This reverts commit e050af2.
This reverts commit 19b6921.
* chore: add tts patch and buildflag, makes tts work again * chore: add tts patch and buildflag, makes tts work again * fix: make things compile * build: add relevant tts files for linux * fix: update patch and patch description, should now compile on mac * build: move chrome specific sources under chromium_src:chrome target * build: enable_extensions again We are depending on them, check `//electron/chromium_src:chrome` target for more info. * fix: update tts.patch to receive notifications about browser context destruction * fix: extend browser process from chrome layer The global state g_browser_process is shared between //chrome and //electron. * spec: add basic speech synthesis test * spec: skip speech tests on ci * build: fix compilation on windows
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backports #16532 to 4-0-x. See that PR for details.
Notes: Fixed an issue where data streamed from registerStreamProtocol could be truncated before completion.