Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't forward IPC filtering events to app for dev-tools and extensions #16565

Merged
merged 1 commit into from Jan 30, 2019
Merged

fix: don't forward IPC filtering events to app for dev-tools and extensions #16565

merged 1 commit into from Jan 30, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 27, 2019 •
edited

Allowing apps to filter the remote module for Chrome dev-tools and/or extensions is not a good idea as it can prevent them from working properly (such as context menu not working)

Checklist

Release Notes

Notes: Electron no longer forwards IPC filtering events to app for dev-tools and extensions.

@miniak miniak self-assigned this Jan 27, 2019
@miniak miniak requested a review from a team January 27, 2019 16:05
@electron electron deleted a comment Jan 30, 2019
@codebytere codebytere merged commit dfcee48 into master Jan 30, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 30, 2019

Release Notes Persisted

Electron no longer forwards IPC filtering events to app for dev-tools and extensions.

@codebytere codebytere deleted the miniak/remote-filter-devtools branch January 30, 2019 16:20
@trop trop bot mentioned this pull request Jan 30, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jan 30, 2019

I have automatically backported this PR to "5-0-x", please check out #16613

@miniak miniak mentioned this pull request Feb 1, 2019
Merged
3 tasks
@miniak
Copy link
Contributor Author

miniak commented Feb 4, 2019

/trop run backport-to 4-0-x

@trop
Copy link
Contributor

trop bot commented Feb 4, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-0-x" here we go! :D

@trop trop bot mentioned this pull request Feb 4, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Feb 4, 2019

I have automatically backported this PR to "4-0-x", please check out #16716

@trop trop bot added the in-flight/4-0-x label Feb 4, 2019
@sofianguy sofianguy added this to 5.0.0-beta.2 in 5.0.x Feb 4, 2019
@miniak miniak mentioned this pull request Feb 11, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.0-beta.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @alexeykuzmin @zcbenz @deepak1556 @codebytere