feat: add ELECTRON_DISABLE_SANDBOX env var #16576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jkleinsc
approved these changes
Jan 29, 2019
zcbenz
approved these changes
Jan 29, 2019
|
Release Notes Persisted
|
|
/trop run backport |
|
The backport process for this PR has been manually initiated, here we go! :D |
|
I have automatically backported this PR to "5-0-x", please check out #16662 |
5 tasks
roramirez
added a commit
to roramirez/MagicMirror
that referenced
this pull request
Jan 20, 2020
New version of Electron has enable by default sandbox http://www.atom.pe/docs/api/sandbox-option/ There was some issues to migrate a new version of Electron for MagicMirror. Using the new version in Travis CI was failing at this time. The problem is because the testing runner is a Docker enviroment The issue experimented is the same topic mentioned here: - electron/electron#17972 - electron-userland/spectron#443 The fix for to all of this is to set the `--no-sandbox` mode in CI testing https://electronjs.org/docs/all#--no-sandbox This change use the feature to set and disable Sandbox using by enviroment variable `ELECTRON_DISABLE_SANDBOX=1` electron/electron#16576 This change has reference MagicMirrorOrg#1800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is to support easy disabling of sandboxing in CI environments, particularly on Linux where running CI inside docker is common, and Chrome's sandboxing technique conflicts with docker's default seccomp profile.
There have been concerns raised over whether this is a potential attack vector (e.g. an attacker who had control over the app's environment could set this variable to permit escalation), but I think there exist other easier routes to escalation if you have control over the environment, e.g.
LD_PRELOADorPATH.Checklist
Release Notes
Notes: Added ELECTRON_DISABLE_SANDBOX environment variable to make it easier to disable sandboxing in Docker-based Linux CI environments.