Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated app.enableMixedSandbox() #17894

Merged
merged 1 commit into from Apr 24, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 21, 2019

Description of Change

Follow up to #15894

Checklist

Release Notes

Notes: Removed deprecated app.enableMixedSandbox() API.

/cc @nornagon

@miniak miniak requested a review from nornagon April 21, 2019 11:00
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 21, 2019
@miniak miniak force-pushed the miniak/remove-mixed-sandbox-api branch 3 times, most recently from 3633464 to d1a3078 Compare April 21, 2019 14:45
@miniak miniak self-assigned this Apr 22, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2019
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we should document the option to disable it entirely with in docs/api/chrome-command-line-switches.md. This looks g2g once that's done tho!

@miniak miniak force-pushed the miniak/remove-mixed-sandbox-api branch from d1a3078 to 36b03fc Compare April 23, 2019 20:29
@miniak miniak requested a review from codebytere April 23, 2019 20:30
@codebytere codebytere merged commit 253d049 into master Apr 24, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 24, 2019

Release Notes Persisted

Removed deprecated app.enableMixedSandbox() API.

@codebytere codebytere deleted the miniak/remove-mixed-sandbox-api branch April 24, 2019 04:07
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants