Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support capslock and numlock as accelerators (backport: 5-0-x) #16725

Merged
merged 2 commits into from Feb 11, 2019
Merged

feat: support capslock and numlock as accelerators (backport: 5-0-x) #16725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6406ed6
feat: support capslock as accelerator
codebytere Feb 4, 2019
fc7527a
also add numlock
codebytere Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions atom/common/keyboard_util.cc
View file
Open in desktop
Expand Up @@ -38,6 +38,10 @@ ui::KeyboardCode KeyboardCodeFromKeyIdentifier(const std::string& s,
} else if (str == "plus") {
*shifted = true;
return ui::VKEY_OEM_PLUS;
} else if (str == "capslock") {
return ui::VKEY_CAPITAL;
} else if (str == "numlock") {
return ui::VKEY_NUMLOCK;
} else if (str == "tab") {
return ui::VKEY_TAB;
} else if (str == "num0") {
Expand Down
2 changes: 2 additions & 0 deletions docs/api/accelerator.md
View file
Open in desktop
Expand Up @@ -58,6 +58,8 @@ The `Super` key is mapped to the `Windows` key on Windows and Linux and
* `Plus`
* `Space`
* `Tab`
* `Capslock`
* `Numlock`
* `Backspace`
* `Delete`
* `Insert`
Expand Down