Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add new webFrame IsolatedWorldInfo API and deprecate #16801

Merged
merged 6 commits into from Feb 13, 2019
Merged

chore: Add new webFrame IsolatedWorldInfo API and deprecate #16801

merged 6 commits into from Feb 13, 2019

Conversation

nitsakh
Copy link
Contributor

@nitsakh nitsakh commented Feb 6, 2019 •
edited

Description of Change

Deprecate and add new webFrame API to support chrome 73 update.
Chromium upgrade commit

Checklist

Release Notes

Notes: Added webFrame.setIsolatedWorldInfo API and deprecated related APIs

@nitsakh nitsakh requested review from a team February 6, 2019 23:14
@codebytere
Copy link
Member

codebytere commented Feb 7, 2019 •
edited

@nitsakh this doesn't seem like it'd be a chore?

@nitsakh
Copy link
Contributor Author

nitsakh commented Feb 7, 2019

@nitsakh this doesn't seem like it'd be a chore?

@codebytere feat?

deepak1556
deepak1556 reviewed Feb 7, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor change on the implementation side. Thanks!

MarshallOfSound
MarshallOfSound requested changes Feb 7, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback around usage of args

atom/renderer/api/atom_api_web_frame.cc Outdated Show resolved Hide resolved
atom/renderer/api/atom_api_web_frame.cc Outdated Show resolved Hide resolved
atom/renderer/api/atom_api_web_frame.cc Outdated Show resolved Hide resolved
MarshallOfSound
MarshallOfSound approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just need to rebase to remove conflicts 👍

@nitsakh nitsakh requested a review from a team February 13, 2019 00:18
@jkleinsc jkleinsc merged commit 3dfef4a into master Feb 13, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 13, 2019

Release Notes Persisted

Added webFrame.setIsolatedWorldInfo API and deprecated related APIs

@trop trop bot mentioned this pull request Feb 13, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Feb 13, 2019

I have automatically backported this PR to "5-0-x", please check out #16932

@nitsakh nitsakh deleted the deprecate-isolated-world branch February 13, 2019 18:25
@MarshallOfSound MarshallOfSound mentioned this pull request Feb 14, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nitsakh @codebytere @deepak1556 @MarshallOfSound @jkleinsc