fix: don't construct submenu if it's invisible #16834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Previously, if a submenu was specified in a template like the following:
The
visible
property of the submenu would be ignored and the menu would be constructed regardless. This adds a check toaddItemToMenu
which matches Chromium's current check in the selfsame method that chooses to not create the submenu if it hasvisible: false
.Checklist
npm test
passesRelease Notes
Notes: Fixed submenus not responding to the
visible: false
MenuItem
property.