Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak when using webFrame and spell checker (backport: 5-0-x) #16851

Merged
merged 2 commits into from Feb 8, 2019
Merged

Fix memory leak when using webFrame and spell checker (backport: 5-0-x) #16851

merged 2 commits into from Feb 8, 2019

Commits on Feb 8, 2019

  1. fix: do not create native api::WebFrame in webFrame 

    When reloading a page without restarting renderer process (for example
sandbox mode), the blink::WebFrame is not destroyed, but api::WebFrame
is always recreated for the new page context. This leaves a leak of
api::WebFrame.
    @zcbenz @electron-bot
    zcbenz authored and electron-bot committed Feb 8, 2019
    Copy the full SHA
    3ae6c62 View commit details
    Browse the repository at this point in the history

  2. fix: remove spell checker when page context is released

    @zcbenz @electron-bot
    zcbenz authored and electron-bot committed Feb 8, 2019
    Copy the full SHA
    c511d29 View commit details
    Browse the repository at this point in the history