feat: allow MenuItems to work optionally when hidden

[codebytere]

Description of Change

Resolves #16747.

This PR enables MenuItems on macOS to work optionally when visible: false. using a new MenuItem option acceleratorWorksWhenHidden. The default of this new options is true, to match behavior on Windows and Linux, but since native macOS development allows for this to be turned off, this option allows that to be done.

Example:

  const menu = Menu.buildFromTemplate([
    {
      label: 'View',
      submenu: [
        { role: 'zoomin' },
        { 
          role: 'zoomout', 
          visible: false,
          acceleratorWorksWhenHidden: true
        },
      ],
    }
  ])

cc @MarshallOfSound @zcbenz

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Added an option to enable MenuItems on macOS to work optionally when visible: false.

[codebytere]

comment removed as it's a remnant of dead code previously removed in #14939

[brenca]

👍

[MarshallOfSound]

Looks like you're gonna need one of those lovely Forward Declarations 😢

../../electron/atom/browser/ui/cocoa/atom_menu_controller.mm:296:11: error: instance method '-setAllowsKeyEquivalentWhenHidden:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
          setAllowsKeyEquivalentWhenHidden:(model->WorksWhenHiddenAt(index))];

[codebytere]

@MarshallOfSound oops yeah i was planning on fixing this yesterday but then gclient died on me; fixing soon :)

[release-clerk]

Release Notes Persisted

Added an option to enable MenuItems on macOS to work optionally when visible: false.

[trop]

I have automatically backported this PR to "5-0-x", please check out #17175