Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow MenuItems to work optionally when hidden (backport: 5-0-x) #17175

Closed
wants to merge 2 commits into from
Closed

feat: allow MenuItems to work optionally when hidden (backport: 5-0-x) #17175

wants to merge 2 commits into from

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 28, 2019

Backport of #16853

See that PR for details.

Notes: Added an option to enable MenuItems on macOS to work optionally when visible: false.

@trop trop bot requested a review from a team February 28, 2019 17:01
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 28, 2019
@trop trop bot requested a review from a team February 28, 2019 17:01
@trop trop bot mentioned this pull request Feb 28, 2019
Merged
5 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Feb 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 28, 2019
MarshallOfSound
MarshallOfSound requested changes Feb 28, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking pending @electron/wg-releases

@codebytere
Copy link
Member

On second thought, i don't believe this passes the bar of necessity for backporting into a stabilization branch. Closing.

@codebytere codebytere closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound requested changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound