Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: finalize dropping support for OS X Mavericks (version 10.9) #17102

Merged
merged 1 commit into from Feb 25, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Feb 24, 2019

Description of Change

Re-apply #13296 after mac: bump deployment target to 10.10
Mostly removes obsolete @available(macOS 10.10, *) checks in the code
Follow up to #15357

/cc @nornagon, @codebytere

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak requested review from a team February 24, 2019 12:05
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 24, 2019
@miniak miniak self-assigned this Feb 24, 2019
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove all of the 10.10 NSColor forward declarations?

@miniak
Copy link
Contributor Author

miniak commented Feb 25, 2019

@codebytere AFAIK those are needed as they are missing from the SDK that we are currently using. Also it's just declaring API availability, which is exactly what the SDK declarations would do.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 25, 2019
@alexeykuzmin alexeykuzmin merged commit 5e762d6 into master Feb 25, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 25, 2019

No Release Notes

@trop
Copy link
Contributor

trop bot commented Feb 25, 2019

I have automatically backported this PR to "5-0-x", please check out #17122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants