Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: finalize dropping support for OS X Mavericks (version 10.9) (backport: 5-0-x) #17122

Merged
merged 1 commit into from Feb 27, 2019
Merged

chore: finalize dropping support for OS X Mavericks (version 10.9) (backport: 5-0-x) #17122

merged 1 commit into from Feb 27, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 25, 2019

Backport of #17102

See that PR for details.

Notes: no-notes

@trop trop bot requested review from a team February 25, 2019 17:22
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 25, 2019
@trop trop bot mentioned this pull request Feb 25, 2019
Merged
3 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Feb 25, 2019
nornagon
nornagon requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be mentioned in the release notes.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 26, 2019
@miniak
Copy link
Contributor

miniak commented Feb 26, 2019 •
edited

@nornagon why? it's not a user observable change (just cleanup after the actual PR, which dropped support for 10.9 before)

@codebytere
Copy link
Member

@miniak we're dropping support for an entire macOS version, this is definitely user observable :)

@miniak
Copy link
Contributor

miniak commented Feb 26, 2019

@codebytere the user visible part of the change was made in master #15357 before 5.0 was branched

nornagon
nornagon approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok then! that's fine :)

@codebytere codebytere merged commit fce543d into electron:5-0-x Feb 27, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 27, 2019

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @codebytere @nornagon