Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add process.getSystemVersion() (backport: 5-0-x) #17141

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 26, 2019

Backport of #16599

See that PR for details.

Notes: Added process.getSystemVersion(), which is available in sandboxed renderers and returns the actual operating system version instead of kernel version on macOS.

@trop trop bot requested review from a team February 26, 2019 17:29
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 26, 2019
@trop trop bot mentioned this pull request Feb 26, 2019
6 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Feb 26, 2019
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs approval from @electron/wg-releases

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 26, 2019
@jkleinsc
Copy link
Contributor

The releases working group decided that this PR should not be merged back to 5-0-x.

@jkleinsc jkleinsc closed this Feb 28, 2019
@miniak
Copy link
Contributor

miniak commented Feb 28, 2019

@jkleinsc can you share more details about the decision?

@jkleinsc
Copy link
Contributor

@miniak the decision was made because of a couple of things:

  1. We decided that the default answer as to whether or not to add a feature once beta starts should be "no". This aligns with our versioning documentation: https://github.com/electron/electron/blob/master/docs/tutorial/electron-versioning.md#beta-releases-and-bug-fixes
  2. There didn't seem to be a clear need for this feature to be added to 5-0-x. If you have a strong case as to why this should be added we might reconsider. In the future we are going to request that anyone who has a feature they want to backport to a beta will need to provide their argument as to why the feature should be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants