New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add process.getSystemVersion() #16599
Conversation
739ab6f
to
7a1a614
Compare
7a1a614
to
d211718
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a procedural matter it might be good to put this up for an emoji-vote on #pineapple since it adds a new feature to a stability branch.
That said, I'm 👍 on this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm actually my last review sends a mixed message of approving + asking for further work.
So I'm giving a "Request changes" here solely as a procedural step of getting team feedback on adding a semver/minor
feature to 5-0-x
d211718
to
4e869b4
Compare
4e869b4
to
32bbcf2
Compare
if we're only targeting master
, the question of semver/minor is moot
Release Notes Persisted
|
/trop run backport-to 5-0-x |
The backport process for this PR has been manually initiated, |
I have automatically backported this PR to "5-0-x", please check out #17141 |
Description of Change
Checklist
npm test
passesRelease Notes
Notes: Added
process.getSystemVersion()
, which is available in sandboxed renderers and returns the actual operating system version instead of kernel version on macOS.