Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add process.getSystemVersion() #16599

Merged
merged 1 commit into from Feb 18, 2019
Merged

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 29, 2019

Description of Change

  • available in sandboxed renderers
  • returns the actual operating system version instead of kernel version on macOS

Checklist

Release Notes

Notes: Added process.getSystemVersion(), which is available in sandboxed renderers and returns the actual operating system version instead of kernel version on macOS.

@miniak miniak requested review from a team January 29, 2019 23:28
@miniak miniak self-assigned this Jan 29, 2019
@ckerr ckerr added the semver/minor backwards-compatible functionality label Jan 30, 2019
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a procedural matter it might be good to put this up for an emoji-vote on #pineapple since it adds a new feature to a stability branch.

That said, I'm 👍 on this PR

ckerr
ckerr previously requested changes Jan 30, 2019
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm actually my last review sends a mixed message of approving + asking for further work.

So I'm giving a "Request changes" here solely as a procedural step of getting team feedback on adding a semver/minor feature to 5-0-x

docs/api/process.md Show resolved Hide resolved
@miniak
Copy link
Contributor Author

miniak commented Feb 14, 2019

@ckerr, @nornagon I've removed the target/5-0-x label + added the example values. Can you please approve?

@jkleinsc jkleinsc requested a review from ckerr February 15, 2019 18:30
@ckerr ckerr dismissed their stale review February 18, 2019 12:59

if we're only targeting master, the question of semver/minor is moot

@ckerr ckerr merged commit a04d9ef into master Feb 18, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 18, 2019

Release Notes Persisted

Added process.getSystemVersion(), which is available in sandboxed renderers and returns the actual operating system version instead of kernel version on macOS.

@ckerr ckerr deleted the miniak/get-system-version branch February 18, 2019 12:59
@miniak
Copy link
Contributor Author

miniak commented Feb 26, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Feb 26, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Feb 26, 2019

I have automatically backported this PR to "5-0-x", please check out #17141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants