fix: bad assertion in crypto functions that use BN_bn2bin_padded #17220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in particular, this picks up electron/node#70a78f07b, which fixes an issue with incorrect usage of the BN_bn2bin_padded API in boringssl
|
This will need a manual backport to 4 and 5. |
nornagon
changed the title
nornagon
changed the title
nornagon
changed the title
6 tasks
codebytere
approved these changes
Mar 4, 2019
|
one error seems to be:
🤔 and the other seems to be
|
|
@nornagon any reason this needs backport to 4.x ? AFAIK the changes on electron/node only made it to electron 5.x branch. |
|
ack, you're right, no need for 4. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #17255 |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
…ctron#17220) * chore: roll node in particular, this picks up electron/node#70a78f07b, which fixes an issue with incorrect usage of the BN_bn2bin_padded API in boringssl * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in particular, this picks up electron/node#70a78f07b, which fixes an issue with incorrect usage of the BN_bn2bin_padded API in boringssl. This also adds tests to make sure those functions are fixed.
Checklist
npm testpassesRelease Notes
Notes: Fixed an assertion when calling
ECDH.getPrivateKey(),diffieHellman.generateKeys()ordiffieHellman.get*().