fix: make StreamSubscriber ref counted #17221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is owned by URLRequestStreamJob on the IO thread once request starts, but if the ownership was abondoned while transfering it to IO thread which is possible when a request is aborted, then we need to make sure its destroyed on the right thread to avoid lock in v8.
|
/cc @pfrazee |
|
Will test this shortly, I'm just fighting with the electron build process |
|
Just tested this against https://github.com/pfrazee/electron-bug-webview-freeze and confirmed the fix works 👍 |
zcbenz
approved these changes
Mar 5, 2019
61 tasks
tarruda
approved these changes
Mar 5, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "4-0-x" cleanly; |
|
I have automatically backported this PR to "5-0-x", please check out #17264 |
6 tasks
|
A maintainer has manually backported this PR to "4-0-x", please check out #17267 |
|
A maintainer has manually backported this PR to "4-1-x", please check out #17267 |
3 tasks
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
It is owned by URLRequestStreamJob on the IO thread once request starts, but if the ownership was abondoned while transfering it to IO thread which is possible when a request is aborted, then we need to make sure its destroyed on the right thread to avoid lock in v8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
It is owned by URLRequestStreamJob on the IO thread once request starts, but if the ownership was abondoned while transfering it to IO thread which is possible when a request is aborted, then we need to make sure its destroyed on the right thread.
Fixes #16881
Checklist
npm testpassesRelease Notes
Notes: Fix app freeze when using custom stream protocol