Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly return properties on the netLog module #17525

Merged
merged 1 commit into from Mar 26, 2019
Merged

fix: correctly return properties on the netLog module #17525

merged 1 commit into from Mar 26, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 24, 2019 •
edited

Description of Change

Fixes #17519.

We were unconditionally assuming all properties on the prototype chain were functions, which wouldn't be true in the case of currentlyLogging and currentlyLoggingPath. This adds a check to return non-function properties correctly.

cc @MarshallOfSound @deepak1556

Checklist

Release Notes

Notes: Fixed an issue with netLog module properties not being returned correctly.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 24, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 25, 2019
@codebytere codebytere merged commit 34eb5d0 into master Mar 26, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 26, 2019

Release Notes Persisted

Fixed an issue with netLog module properties not being returned correctly.

@codebytere codebytere deleted the fix-netlog branch March 26, 2019 02:40
@trop trop bot mentioned this pull request Mar 26, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Mar 26, 2019

I have automatically backported this PR to "4-1-x", please check out #17544

@trop trop bot removed the target/4-1-x label Mar 26, 2019
@trop trop bot mentioned this pull request Mar 26, 2019
Merged
@trop trop bot added the in-flight/4-1-x label Mar 26, 2019
@trop
Copy link
Contributor

trop bot commented Mar 26, 2019

I have automatically backported this PR to "5-0-x", please check out #17545

kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
fix: correctly return properties on the netLog module (electron#17525)
380fcb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound