fix: use file path as key for safeDialogs on filesystem

[MarshallOfSound]

Description of Change

file:// protocol URLs weren't getting valid keys for the count store.

Notes: The safeDialogs webPreferences option now actually works on file:// URLs

[PalmerAL]

@MarshallOfSound The option doesn't appear to work correctly even if I modify the webContents to use a http:// URL, so I'm guessing there may be more than one bug preventing this from working.

[MarshallOfSound]

@PalmerAL I just checked 5.0.0-beta.6 without this change and it works fine for http:// URLs. With this change it also works for file:// URLs

[PalmerAL]

@MarshallOfSound Interesting, I'm testing with the same version of Electron, and it definitely doesn't work for me.

Code:

  mainWindow = new BrowserWindow({
    width: 800,
    height: 600,
    webPreferences: {
      nodeIntegration: false,
      safeDialogs: true
    }
  })

  // and load the index.html of the app.
  mainWindow.loadURL('https://electronjs.org/')

  // Open the DevTools.
  mainWindow.webContents.openDevTools()

Screen recording:
electron-safe-dialogs.zip

[codebytere]

@MarshallOfSound should we wait for further investigation of the above before merging?

[MarshallOfSound]

@codebytere I want to merge this as the issue is definitely fixed on master on both file:// and http://. I have removed the "Fixes #X" though to leave that issue open for more investigation into 5.x.

[release-clerk]

Release Notes Persisted

The safeDialogs webPreferences option now actually works on file:// URLs

[trop]

I have automatically backported this PR to "5-0-x", please check out #17579