Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update patch to make Windows key work with global shortcuts #17565

Merged
merged 1 commit into from Mar 28, 2019
Merged

fix: update patch to make Windows key work with global shortcuts #17565

merged 1 commit into from Mar 28, 2019

Conversation

brenca
Copy link
Contributor

@brenca brenca commented Mar 27, 2019

Description of Change

Fixes #17246.

Checklist

Release Notes

Notes: Fixed a bug which caused global shortcuts with the Windows key not to work properly on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 27, 2019
@brenca brenca requested a review from a team as a code owner March 27, 2019 10:15
@brenca
Copy link
Contributor Author

brenca commented Mar 27, 2019

Manual backport at #17566

@brenca brenca mentioned this pull request Mar 27, 2019
Merged
4 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 28, 2019
@MarshallOfSound MarshallOfSound merged commit 7a47e64 into master Mar 28, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 28, 2019

Release Notes Persisted

Fixed a bug which caused global shortcuts with the Windows key not to work properly on Windows.

@MarshallOfSound MarshallOfSound deleted the brenca/fix-windows-global-shortcut branch March 28, 2019 18:15
@trop
Copy link
Contributor

trop bot commented Mar 28, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17566

@deepak1556 deepak1556 mentioned this pull request Apr 3, 2019
Merged
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@brenca @kiku-jw
fix: update patch to make Windows key work with global shortcuts (ele…
308cfcd 
…ctron#17565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brenca @codebytere @MarshallOfSound