build: disable Vulkan support by default

[alexeykuzmin]

Maybe it shouldn't be done in the master but only in v4 and 5.

Description of Change

It was enabled in
https://chromium.googlesource.com/chromium/src.git/+/327326656f2c8c45ecb0ff4675e5c577e7c275ef which landed in 69.0.3460.0 (Electron 4).

Vulkan support would require a command line parameter "--enable-vulkan"
to be passes to a binary to be enabled anyway,
so this change doesn't actually alter the current behaviour of Electron.

Reasons to disable the flag back:

1. Electron has never supported it prior to version 4.
2. We build stuff we don't need.
3. We ship stuff we don't use, and Vulkan's DLLs size is > 0.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Disabled unintentionally enabled Vulkan support.

[nornagon]

I wouldn't say this was unintentionally enabled. We inherit changes in Chrome intentionally.

Vulkan will eventually be required in Chrome (to support WebGPU, and additionally because OpenGL is deprecated on macOS), so we can't disable this forever. Disabling it in 4 and 5 might be reasonable if it's not usable/useful there anyway. What's the difference in binary size? If it's less than ~1MiB I don't think we should bother, since it will be required eventually anyway.

[miniak]

@nornagon on 64-bit Windows builds, the Vulkan binaries are 12 MB uncompressed (approx 2.5 MB compressed). Shipping this much dead code seems really wasteful.

[miniak]

@nornagon even the latest version of Chrome on Windows does not include these Vulkan DLLs.

[alexeykuzmin]

I wouldn't say this was unintentionally enabled. We inherit changes in Chrome intentionally.

The thing is enabled by default in Chromium, but I'm not sure about Chrome.
Milan states above that there are no Vulcan DLLs present in the latest GC on Windows.

[alexeykuzmin]

Disabling it in 4 and 5 might be reasonable if it's not usable/useful there anyway.

5-0-x #17788
4-1-x #17789

[alexeykuzmin]

We are going to leave it as is in the master and only make the change in 4-1-x and 5-0-x.