Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: disable Vulkan validation layers #17985

Merged
merged 1 commit into from Apr 30, 2019
Merged

build: disable Vulkan validation layers #17985

merged 1 commit into from Apr 30, 2019
+1 −0

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 26, 2019 •
edited

Description of Change

Removes the following DLLs from the build, which are only meant to be used for Chromium development:

  • VkLayer_core_validation.dll
  • VkLayer_object_tracker.dll
  • VkLayer_parameter_validation.dll
  • VkLayer_threading.dll
  • VkLayer_unique_objects.dll

angle.gni for more details

Follow up to #17694

Checklist

Release Notes

Notes: Removed Vulkan validation layers DLLs from electron.zip, which are only meant to be used for Chromium development.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 26, 2019
@miniak miniak requested a review from nornagon April 26, 2019 13:37
@miniak miniak marked this pull request as ready for review April 26, 2019 13:37
@miniak miniak self-assigned this Apr 26, 2019
@miniak miniak force-pushed the miniak/disable-vulkan-validation-layers branch from 8626f19 to 5f4c79a Compare April 26, 2019 15:52
This was referenced Apr 26, 2019
Merged
Merged
@miniak miniak changed the title chore: disable Vulkan validation layers build: disable Vulkan validation layers Apr 26, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 26, 2019
deepak1556
deepak1556 approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it still makes sense to disable vulkan code if its not being used. enable_vulkan=false

nornagon
nornagon approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with @deepak1556, I think we should revert the change and leave enable_vulkan at its default as it doesn't cost us much to leave it enabled.

@deepak1556
Copy link
Member

leave enable_vulkan at its default as it doesn't cost us much to leave it enabled.

whats the benefit of this ?

@nornagon
Copy link
Member

It keeps us closer to Chromium's configuration. I'd rather ask, what's the benefit of disabling it? :)

@deepak1556
Copy link
Member

Cool, I am not super tied to my argument, but just that what we are doing is just disabling a subset argument to achieve the main purpose, while the main gateway for vulkan in the codebase is enable_vulkan. But if we are going to be using vulkan when chrome enables it, then this change makes sense.

@nornagon
Copy link
Member

If we're going to backport this everywhere that the enable_vulkan patch went, we should revert that in this PR as well so we only have to deal with one set of backports.

@miniak
Copy link
Contributor Author

miniak commented Apr 29, 2019

@nornagon, we only did that in 4-1-x and 5-0-x

@miniak
Copy link
Contributor Author

miniak commented Apr 29, 2019

#17694 was abandoned

@jkleinsc jkleinsc merged commit e9d88e9 into master Apr 30, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 30, 2019

Release Notes Persisted

Removed Vulkan validation layers DLLs from electron.zip, which are only meant to be used for Chromium development.

@trop trop bot mentioned this pull request Apr 30, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Apr 30, 2019

I have automatically backported this PR to "4-1-x", please check out #18060

This was referenced Apr 30, 2019
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Apr 30, 2019

I have automatically backported this PR to "5-0-x", please check out #18061

@trop trop bot removed the target/4-1-x label Apr 30, 2019
@trop
Copy link
Contributor

trop bot commented Apr 30, 2019

I have automatically backported this PR to "6-0-x", please check out #18062

@jkleinsc jkleinsc deleted the miniak/disable-vulkan-validation-layers branch April 30, 2019 13:46
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
chore: disable Vulkan validation layers (electron#17985)
7cef01c
@miniak miniak mentioned this pull request May 31, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @deepak1556 @nornagon @alexeykuzmin @jkleinsc