Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated app.enableMixedSandbox() #17894

Merged
merged 1 commit into from Apr 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/api/breaking-changes.md
Expand Up @@ -81,6 +81,15 @@ powerMonitor.querySystemIdleTime(callback)
const idleTime = getSystemIdleTime()
```

## `app.enableMixedSandbox`

```js
// Deprecated
app.enableMixedSandbox()
```

Mixed-sandbox mode is now enabled by default.
miniak marked this conversation as resolved.
Show resolved Hide resolved

## Preload scripts outside of app path are not allowed

For security reasons, preload scripts can only be loaded from a subpath of the [app path](app.md#appgetapppath).
Expand Down
5 changes: 5 additions & 0 deletions docs/api/chrome-command-line-switches.md
Expand Up @@ -181,6 +181,11 @@ logging level for all code in the source files under a `foo/bar` directory.

This switch only works when `--enable-logging` is also passed.

## --no-sandbox

Disables Chromium sandbox, which is now enabled by default.
Should only be used for testing.

[app]: app.md
[append-switch]: app.md#appcommandlineappendswitchswitch-value
[ready]: app.md#event-ready
Expand Down
5 changes: 1 addition & 4 deletions lib/browser/api/app.ts
Expand Up @@ -32,10 +32,7 @@ Object.assign(app, {
getSwitchValue: (theSwitch: string) => commandLine.getSwitchValue(String(theSwitch)),
appendSwitch: (theSwitch: string, value?: string) => commandLine.appendSwitch(String(theSwitch), typeof value === 'undefined' ? value : String(value)),
appendArgument: (arg: string) => commandLine.appendArgument(String(arg))
} as Electron.CommandLine,
enableMixedSandbox () {
deprecate.log(`'enableMixedSandbox' is deprecated. Mixed-sandbox mode is now enabled by default. You can safely remove the call to enableMixedSandbox().`)
}
} as Electron.CommandLine
})

// we define this here because it'd be overly complicated to
Expand Down