Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting of global fallback user agent (backport for 6-0-x) #18473

Merged
merged 1 commit into from May 28, 2019

Conversation

felixrieseberg
Copy link
Member

Backport of #18016

See that PR for details. Approved for 4.2.0 backport by @electron/wg-releases on 01/05/19, so presumably we want it in 6.0.x, too :P

Notes: Added new app.userAgentFallback property to allow setting the apps useragent globally

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved given approval precedent for 4-2-x!

@MarshallOfSound MarshallOfSound merged commit f7d4d51 into 6-0-x May 28, 2019
@MarshallOfSound MarshallOfSound deleted the 6x-feat/set-user-agent-globally branch May 28, 2019 19:25
@release-clerk
Copy link

release-clerk bot commented May 28, 2019

Release Notes Persisted

Added new app.userAgentFallback property to allow setting the apps useragent globally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants