feat: migrate protocol module to NetworkService (Part 6) #18223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
ns-protocol-stream-enhancements
branch
from
b923e22
to
94f64a7
Compare
|
No Release Notes |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
) * fix: start node strem asyncly * fix: headers value may be a list * fix: simply destruct on finish/error * fix: class may destruct immediately after subscribing "data" * fix: send meaningful error * fix: must always provide a response body * fix: handle the case when one write can not write all data * fix: handle connection error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #15791.
This PR fixes large file handling when using
registerStreamProtocolAPI with NetworkService enabled, allregisterStreamProtocoltests are passing now.The
NodeStreamLoaderis also refactored to usepaused modeto read data fromReadablestream, so we don't need to copy data from buffer and hold it in memory, and we only need to make sure the passedBufferis alive while writing data to pipe.Checklist
npm testpassesRelease Notes
Notes: no-notes