Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate protocol module to NetworkService (Part 6) #18223

Merged
merged 8 commits into from
May 11, 2019
Merged

feat: migrate protocol module to NetworkService (Part 6) #18223

merged 8 commits into from
May 11, 2019

Commits on May 10, 2019

  1. fix: start node strem asyncly

    @zcbenz
    zcbenz committed May 10, 2019
    Configuration menu
    Copy the full SHA
    689cd51 View commit details
    Browse the repository at this point in the history

  2. fix: headers value may be a list

    @zcbenz
    zcbenz committed May 10, 2019
    Configuration menu
    Copy the full SHA
    1a8789a View commit details
    Browse the repository at this point in the history

  3. fix: simply destruct on finish/error

    @zcbenz
    zcbenz committed May 10, 2019
    Configuration menu
    Copy the full SHA
    348dcb1 View commit details
    Browse the repository at this point in the history

  4. fix: class may destruct immediately after subscribing "data"

    @zcbenz
    zcbenz committed May 10, 2019
    Configuration menu
    Copy the full SHA
    618d716 View commit details
    Browse the repository at this point in the history

  5. fix: send meaningful error

    @zcbenz
    zcbenz committed May 10, 2019
    Configuration menu
    Copy the full SHA
    afa0b69 View commit details
    Browse the repository at this point in the history

  6. fix: must always provide a response body

    @zcbenz
    zcbenz committed May 10, 2019
    Configuration menu
    Copy the full SHA
    e207a1d View commit details
    Browse the repository at this point in the history

  7. fix: handle the case when one write can not write all data

    @zcbenz
    zcbenz committed May 10, 2019
    Configuration menu
    Copy the full SHA
    fed93cf View commit details
    Browse the repository at this point in the history

  8. fix: handle connection error

    @zcbenz
    zcbenz committed May 10, 2019
    Configuration menu
    Copy the full SHA
    94f64a7 View commit details
    Browse the repository at this point in the history