Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default enable_negotiate_port to false #18251

Merged
merged 1 commit into from May 13, 2019
Merged

Conversation

nornagon
Copy link
Member

Description of Change

The default value of this was switched from false to true in this CL, which we inherited as part of the M69 upgrade. I'm unsure, but I think this might be responsible for #17111 and similar Kerberos-related issues. In any case, it makes sense to keep the default the same as before (and the same as Chrome, which forces this option to false, despite the interface defaulting it to true).

See https://chromium.googlesource.com/chromium/src/+/69.0.3497.128/net/http/http_auth_handler_negotiate.cc#142 for some context about what this feature does.

Checklist

Release Notes

Notes: Fixed a regression in Kerberos SPN generation. In the M69 upgrade, the default for the enable_negotiate_port option was inadvertently changed from false to true; this restores the former behavior and aligns with Chromium.

@nornagon nornagon requested a review from deepak1556 May 10, 2019 21:31
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 10, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 11, 2019
@felixrieseberg
Copy link
Member

/trop backport-to 4-2-x

@trop
Copy link
Contributor

trop bot commented May 13, 2019

@felixrieseberg is not authorized to run PR backports.

@nornagon
Copy link
Member Author

/trop run backport-to 4-2-x

@trop
Copy link
Contributor

trop bot commented May 13, 2019

This PR has not been merged yet, and cannot be backported.

@nornagon nornagon merged commit 78d45a1 into master May 13, 2019
@release-clerk
Copy link

release-clerk bot commented May 13, 2019

Release Notes Persisted

Fixed a regression in Kerberos SPN generation. In the M69 upgrade, the default for the enable_negotiate_port option was inadvertently changed from false to true; this restores the former behavior and aligns with Chromium.

@trop
Copy link
Contributor

trop bot commented May 13, 2019

I was unable to backport this PR to "4-2-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented May 13, 2019

I have automatically backported this PR to "5-0-x", please check out #18284

@trop
Copy link
Contributor

trop bot commented May 13, 2019

I have automatically backported this PR to "6-0-x", please check out #18285

@trop
Copy link
Contributor

trop bot commented May 13, 2019

A maintainer has manually backported this PR to "4-2-x", please check out #18287

1 similar comment
@trop
Copy link
Contributor

trop bot commented May 13, 2019

A maintainer has manually backported this PR to "4-2-x", please check out #18287

nornagon added a commit that referenced this pull request May 14, 2019
* fix: default enable_negotiate_port to false (#18251)

* chore: command_line is not a pointer
@trop trop bot added the merged/5-0-x label May 15, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@sofianguy sofianguy added this to Fixed in 5.0.2 in 5.0.x Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.2
Development

Successfully merging this pull request may close these issues.

None yet

4 participants