fix: don't export private V8 symbols that can cause native node modules to crash

[torycl]

Description of Change

This change stops private V8 symbols and internal CRT methods being exported. It fixes an issue where native node modules can import incorrect CRT methods and crash on Windows.

• Windows specific
• Directly disables exporting all symbols decorated with V8_EXPORT_PRIVATE
• Removes std::basic_ostream from node.lib which causes crashes if node modules use std::ostream
• Removes v8::internal from node.lib
• Makes electron binary smaller
• Native node module can be now linked with dynamic CRT on Windows

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Removed incorrectly published internal V8 symbols and CRT methods from node.lib, causing heap corruptions with node modules using the dynamic CRT on Windows.

[miniak]

Related to #14617 (comment)

[nornagon]

@miniak that comment is about STL symbols, which this PR doesn't affect.

[torycl]

@miniak that comment is about STL symbols, which this PR doesn't affect.

Actually this PR is also about STL symbols. std::basic_ostream is in description of this PR from the beginning. I am trying to fix issue @miniak reported. That was originally the main goal of my work.
Removing private V8 symbols will make API surface smaller (less opportunities for mistakes) and it will also remove those stl symbols which causes crashes in node modules.
Reduced size of node.lib is nice bonus. Performance impact is very small. Build times are the same.

[nornagon]

Oh huh. How does exporting the V8_EXPORT_PRIVATE symbols cause those STL symbols to be exported..? Perhaps I'm missing something about how dllexport works 🤔

[torycl]

Oh huh. How does exporting the V8_EXPORT_PRIVATE symbols cause those STL symbols to be exported..? Perhaps I'm missing something about how dllexport works 🤔

Exactly! I don't know. I have just tested it fixes our issues and it makes Electron 4 in Teams Desktop App much better. This is the reason I am quite hesitant to publish this change to full PR. First, I would like to know if this will be useful for somebody else. Or, in the meantime, I can find some better solution.

[nornagon]

As written, I think this might impair our ability to run v8 tests in component mode. cc @alexeykuzmin

This could potentially be upstreamable if it were written as something like

#if !defined(HIDE_PRIVATE_SYMBOLS)
#ifdef BUILDING_V8_SHARED
#define V8_EXPORT_PRIVATE __declspec(dllexport)
#elif USING_V8_SHARED
#define V8_EXPORT_PRIVATE __declspec(dllimport)
#else
#define V8_EXPORT_PRIVATE
#endif
#else
#define V8_EXPORT_PRIVATE
#endif

[nornagon]

Looks like the build is broken because master is broken. See #18443

[trop]

A maintainer has manually backported this PR to "6-0-x", please check out #18619

[trop]

A maintainer has manually backported this PR to "5-0-x", please check out #18620

[trop]

A maintainer has manually backported this PR to "4-2-x", please check out #18621